Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::adaptors::reverse with std::vector::reverse #3738

Merged
1 commit merged into from
Oct 23, 2021
Merged

Replace boost::adaptors::reverse with std::vector::reverse #3738

1 commit merged into from
Oct 23, 2021

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Replace boost::adaptors::reverse with std::vector::rbegin/end

@ghost ghost requested review from ranisalt and DSpeichert October 15, 2021 13:32
@ghost ghost requested review from kornholi, nekiro and yamaken93 October 16, 2021 16:18
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer the range-for version, and I would wait until C++20 to replace it with ranges::views::reverse if we are to replace Boost, but that's okay

Copy link
Contributor

@MillhioreBT MillhioreBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested.

@ghost ghost merged commit d057d51 into otland:master Oct 23, 2021
@ghost ghost deleted the replace-bar-with-vr branch October 23, 2021 04:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants