Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Visual Studio project file #3794

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Updated Visual Studio project file #3794

merged 2 commits into from
Dec 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2021 •
edited by ghost
Loading

Pull Request Prelude

Changes Proposed

  • Updated toolset from version 142 to 143
  • Renamed folder from vc14 to vc17 (minor/aesthetical change that should've been done years ago) to comply with MSVS 2022 file version (it was done here once)
  • maybe a couple guides will need a small rewrite after using vc14 folder for so long, but its fine

If you are not a Windows developer/user:

But want to know what is new on MSVS 2022, click here
best part: it finally runs natively on 64x bits

@ghost
Copy link
Author

ghost commented Nov 18, 2021

and yes, I've tested it, everything working flawlessly

@ghost ghost mentioned this pull request Nov 18, 2021
Closed
@ghost ghost requested review from DSpeichert, kornholi and nekiro November 18, 2021 01:21
@ghost ghost added the priority: low Issues with this label won’t have the immediate focus label Nov 18, 2021
@marmichalski
Copy link
Contributor

Why 17 when the version is 15 and you did not change these? 🤔

forgottenserver/vc14/theforgottenserver.sln

Line 3 in f3e6de0

# Visual Studio 15

forgottenserver/vc14/theforgottenserver.vcxproj

Line 2 in f3e6de0

<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

@ghost
Copy link
Author

ghost commented Nov 18, 2021

Why 17 when the version is 15 and you did not change these? 🤔

forgottenserver/vc14/theforgottenserver.sln

Line 3 in f3e6de0

# Visual Studio 15

forgottenserver/vc14/theforgottenserver.vcxproj

Line 2 in f3e6de0

<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

u happy now?

@Erza
Copy link
Contributor

Erza commented Dec 3, 2021

Why 17 when the version is 15 and you did not change these? 🤔

Version number is 17 https://en.wikipedia.org/wiki/Microsoft_Visual_Studio#History

@marmichalski
Copy link
Contributor

Why 17 when the version is 15 and you did not change these? 🤔

Version number is 17 https://en.wikipedia.org/wiki/Microsoft_Visual_Studio#History

That's what I've meant. The version was left at 15.x in the files I've linked. Reading my comment now, and it's not clear for me too, but the attached snippets helped me 🥸
Also @EPuncker understood it and updated the files 🥦

@DSpeichert DSpeichert merged commit 7f78aff into otland:master Dec 14, 2021
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Jan 30, 2022
@Znote
Updated Visual Studio project file (otland#3794)
61dacd4
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@DSpeichert
Updated Visual Studio project file (#3794)
de57a18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kornholi kornholi Awaiting requested review from kornholi

@nekiro nekiro Awaiting requested review from nekiro

Assignees
No one assigned
Labels
priority: low Issues with this label won’t have the immediate focus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marmichalski @Erza @DSpeichert