Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The equivalent of #3609 but for the onItemMoved event #3804

Merged
1 commit merged into from
Nov 28, 2021
Merged

The equivalent of #3609 but for the onItemMoved event #3804

1 commit merged into from
Nov 28, 2021

Conversation

MillhioreBT
Copy link
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

As the title says, Player.onItemMoved not being called when switching items in inventory.

Important

I am not 100% sure if the method should be called exactly where I have declared it, but I hope you can help me and tell me if it is ok or if this should be moved to another place ;)

Similar Issues addressed: #3609

Copy link
Contributor

@Zbizu Zbizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works
no duplicate calls

@ghost ghost merged commit 6f7d0a5 into otland:master Nov 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants