Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous datapack related changes/additions #3810

Merged
merged 10 commits into from
Dec 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2021

Pull Request Prelude

Changes Proposed

  • added new achievements to the lib
  • added potion talktype
  • knights now can use strong mana potion and paladins are able to use great mana potion
  • updated empty potion flask descriptions and fixed a wrongly named one
  • added new distance weapons
  • Added familiars (only files) also added summon challenge spell used by them
  • updated sweet mangonaise elixir description
  • updated shiny blade attack and defense modifier
  • added new food

Evil Puncker added 2 commits November 28, 2021 03:06
- added potion talktype
- knights now can use strong mana potion and paladns are able to use great mana potion
@Zbizu
Copy link
Contributor

Zbizu commented Nov 28, 2021

(this isn't a request for changes, just a note)

There are achievement ids hardcoded in the new client. A new value in achievements table (clientId) or a map (serverId to clientId) could be used to link that system more easily.

Evil Puncker added 8 commits November 28, 2021 03:48
and fixed a wrongly named one
reason of having two diamond arrows: they added the first one as expirable item, and then added second one as non expirable instead of editing the first one
also added summon challenge spell used by them
accordingly to 12.31.9604 update
@ghost ghost marked this pull request as ready for review November 28, 2021 22:17
@ghost ghost requested review from DSpeichert, nekiro and ranisalt November 28, 2021 22:23
@DSpeichert DSpeichert merged commit 33f5bb7 into otland:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants