Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove else after returning branch #4048

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Remove else after returning branch #4048

merged 2 commits into from
Apr 2, 2022

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Remove else after returning branch.

Continues #3678

@ramon-bernardo ramon-bernardo requested a review from a user March 29, 2022 22:07
ghost
ghost previously approved these changes Mar 29, 2022
View reviewed changes
@ghost ghost requested review from DSpeichert and ranisalt March 29, 2022 23:31
ranisalt
ranisalt reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair I couldn't care less 😆 how did you find these? There may be more lurking around the code.

@ramon-bernardo
Copy link
Contributor Author

ramon-bernardo commented Mar 30, 2022 •
edited
Loading

To be fair I couldn't care less 😆 how did you find these? There may be more lurking around the code.

I use regex and some keywords

@DSpeichert DSpeichert merged commit ba09fb4 into otland:master Apr 2, 2022
@ramon-bernardo ramon-bernardo deleted the remove-else-after-returning-branch branch April 2, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt ranisalt left review comments

@DSpeichert DSpeichert DSpeichert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramon-bernardo @DSpeichert @ranisalt