Fix world light config

[ramon-bernardo]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

• Move world light config to game core

Issues addressed:
#4621

[omarcopires]

we had everything centralized in config.lua, now we have several scripts with several different configurations, this is a great return.

[Sajgon]

Why is the config of defaultWorldLight even a thing? there's nothing in the code to handle it being false

[Sajgon]

I think there's another issue with world light @ramon-bernardo

Here it's returned as "worldLightLevel, worldLightColor"

	function Game.getWorldLight()
		return worldLightLevel, worldLightColor
	end

but on other places it's fetched as:
local worldLightColor, worldLightLevel = Game.getWorldLight()

[amatria]

LGTM

[amatria]

Is this comment still true? Is it handled in the sources or is it handled in Lua? data/scripts/globalevents/world_light.lua seems to be doing just that.

[amatria]

we had everything centralized in config.lua, now we have several scripts with several different configurations, this is a great return.

You are absolutely right. It is a pity this parameter is now decentralized. However, #4583 moved the world light algorithm to Lua and so it does not make sense to keep that parameter in the config.lua anymore. But again, I get you. Stating the intent behind this PR would probably reduce the amount of eyebrows raised.

Why is the config of defaultWorldLight even a thing? there's nothing in the code to handle it being false

Not at all. What if I want to make my own world light algorithm? I need this switch to turn the default behavior off. While it is true that there is no code to handle it being false, I could very well add my own.

[MillhioreBT]

If it will no longer be a configuration then make the variable local, since it will only be used in that specific place, if someone changes it to false they know they have to create their own lighting system and they do not have to check if it is false or true elsewhere

Honestly, it doesn't bother me that this boolean is in the Lua configuration, it can be accessed from anywhere and it also doesn't litter the global environment with global variables.

[ramon-bernardo]

Similar #4790