Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost::variant to std::variant #4778

Closed
wants to merge 2 commits into from
Closed

boost::variant to std::variant #4778

wants to merge 2 commits into from

Conversation

maattch
Copy link
Contributor

@maattch maattch commented Aug 27, 2024

Pull Request Prelude

Changes Proposed

Replaces boost variant by std variant, one less boost dependency.
Also fix visual studio compile warnings

Issues addressed:
none

@maattch
Copy link
Contributor Author

maattch commented Oct 7, 2024

Closed in favor of #4805, #4799 and #4795.

@maattch maattch closed this Oct 7, 2024
@maattch maattch deleted the replace-boost-variant branch December 11, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt Awaiting requested review from ranisalt

@EvilHero90 EvilHero90 Awaiting requested review from EvilHero90

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@nekiro nekiro Awaiting requested review from nekiro

@MillhioreBT MillhioreBT Awaiting requested review from MillhioreBT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maattch