Wildcard tree search enhancement and tests #4781
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed:
Tests: Added comprehensive unit tests to verify the functionality of the
WildcardTree
.Code modernization: Utilized
auto
in appropriate places to enhance code readability and maintainability. For further insights, please refer to Herb Sutter's explanation.Function renaming: Updated function names to follow snake_case for consistency with modern C++.
Search behavior refinement: Modified the
search
function to return a more descriptive result using a pair consisting of a customSearchResult
enum and the matched string. This change eliminates the need for the previousReturnValue
.Namespace: Removed the instantiation of a root, updating all usages to directly utilize the
tfs::game::wildcardtree
namespace, which enhances clarity and reduces potential errors.Memory management improvements
std::shared_ptr
for improved memory safety, significantly reducing the risk of memory leaks and ensuring proper resource management throughout theWildcardTree
implementation.Usage