-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor vocations: Reload, extracted into tfs::game::vocations namespace and code improvements #4807
Open
ramon-bernardo
wants to merge
8
commits into
otland:master
Choose a base branch
from
ramon-bernardo:vocation-reload-and-safety-shared
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor vocations: Reload, extracted into tfs::game::vocations namespace and code improvements #4807
ramon-bernardo
wants to merge
8
commits into
otland:master
from
ramon-bernardo:vocation-reload-and-safety-shared
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The future idea is to move most or all of |
return 1600 * std::pow(manaMultiplier, static_cast<int32_t>(magLevel - 1)); | ||
} | ||
|
||
bool tfs::game::vocations::load_from_xml(std::istream& is, std::string_view filename, bool reload) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
Poorly documented function: fewer than 2% comments for a function of 112 lines.
ghost
self-requested a review
October 9, 2024 00:41
ghost
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
tfs::game::vocations
namespace to organize vocation-related logic in a more structured way.std::shared_ptr
for improved memory management and safety.load_from_xml(...)
to load vocation data from an XML file, with an option to reload existing data.find_by_id(uint16_t id)
find_by_name(std::string_view name)
find_by_promoted_id(uint16_t id)
Note: It is not possible to delete a vocation at runtime; only to modify or add new ones.
Before reload.
After changed and reload.
Usage