Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normal build #4875

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ArturKnopik
Copy link
Contributor

@ArturKnopik ArturKnopik commented Dec 18, 2024

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fix normal build by Visual Studio.
Explicitly specifying src folder as include folder, fixing include otpch.h in http module.

Issues addressed:

Can't build project using normal build.

How to test:
Visual Studio

  1. Open projec property page
  2. Go to C/C++ -> Unity Build
  3. Set "Include In Unity File" to no
  4. Build project

Linux

  1. Open CMakeList.txt in src folder
  2. Remove "set_target_properties(tfslib PROPERTIES UNITY_BUILD ${ENABLE_UNITY_BUILD})"
  3. Open CMakeList.txt in src/http folder
  4. Remove "set_target_properties(tfslib PROPERTIES UNITY_BUILD ${ENABLE_UNITY_BUILD})"
  5. Build project

@ArturKnopik ArturKnopik requested review from nekiro and ranisalt and removed request for nekiro December 18, 2024 21:09
@ArturKnopik ArturKnopik marked this pull request as draft December 18, 2024 21:12
@ArturKnopik ArturKnopik changed the title Fix normal build VS project [WIP] Fix normal build VS project Dec 18, 2024
@ArturKnopik ArturKnopik changed the title [WIP] Fix normal build VS project Fix normal build Dec 18, 2024
@ArturKnopik ArturKnopik marked this pull request as ready for review December 18, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant