Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for callbacks and inner module members #40

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Fixes for callbacks and inner module members #40

merged 1 commit into from
Aug 15, 2018

Conversation

tineheller
Copy link
Collaborator

  • Tests are still missing, so the issues shouldn't be closed. Anyway I'd like to merge the changes.
  • I added two examples for modules. I think they are helpful, because modules behave a bit different.

wehrstedt
wehrstedt reviewed Aug 13, 2018
View reviewed changes
exampleProject/src/core/myModule2.js
* inner function
* @function myFunction2
* @param {string} myString
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you have to add "@inner" here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the inner flag is automatically set in this case. I will document the examples in the issue.

@wehrstedt wehrstedt merged commit f6836e6 into otris:master Aug 15, 2018
@wehrstedt wehrstedt mentioned this pull request Aug 15, 2018
Closed
@tineheller tineheller mentioned this pull request Aug 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wehrstedt wehrstedt wehrstedt left review comments

Assignees

@wehrstedt wehrstedt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tineheller @wehrstedt