Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add yapf config to pyproject.toml #230

Merged
merged 2 commits into from
Jan 6, 2023
Merged

chore: add yapf config to pyproject.toml #230

merged 2 commits into from
Jan 6, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

This PR aims to drop the .style.yapf file in favour of pyproject.toml in order to have a more minimal project structure.

Reference: Following google/yapf#708, pyproject.toml support was added.

@codecov-commenter
Copy link

Codecov Report

Merging #230 (b08c1a2) into main (058ce10) will decrease coverage by 7.37%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   89.21%   81.84%   -7.38%     
==========================================
  Files          52       52              
  Lines        5315     5315              
  Branches      549      549              
==========================================
- Hits         4742     4350     -392     
- Misses        438      810     +372     
- Partials      135      155      +20     
Impacted Files Coverage Δ
src/ott/solvers/linear/discrete_barycenter.py 20.73% <0.00%> (-65.86%) ⬇️
src/ott/tools/segment_sinkhorn.py 43.75% <0.00%> (-56.25%) ⬇️
src/ott/solvers/quadratic/gw_barycenter.py 30.47% <0.00%> (-53.34%) ⬇️
src/ott/problems/quadratic/gw_barycenter.py 28.18% <0.00%> (-44.55%) ⬇️
src/ott/geometry/segment.py 62.22% <0.00%> (-37.78%) ⬇️
src/ott/tools/sinkhorn_divergence.py 63.15% <0.00%> (-35.09%) ⬇️
src/ott/tools/soft_sort.py 69.90% <0.00%> (-25.25%) ⬇️
src/ott/geometry/pointcloud.py 71.09% <0.00%> (-14.46%) ⬇️
src/ott/geometry/graph.py 77.50% <0.00%> (-14.38%) ⬇️
src/ott/problems/linear/potentials.py 79.34% <0.00%> (-9.79%) ⬇️
... and 21 more

@michalk8
Copy link
Collaborator

michalk8 commented Jan 6, 2023

LGTM, thanks!

@michalk8 michalk8 merged commit a6feea4 into ott-jax:main Jan 6, 2023
@SauravMaheshkar SauravMaheshkar deleted the drop-yapf-style branch January 6, 2023 14:16
michalk8 pushed a commit that referenced this pull request Jun 27, 2024
* style(yapf): add yapf config to `pyproject.toml`

* style(yapf): drop `.style.yapf`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants