Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runStatus does not support all the Github Run statuses, specific Waiting is missing #484

Closed
globaltopmedia opened this issue Oct 18, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@globaltopmedia
Copy link

Workflows which are in the status Waiting will cause a java error as they are not part of the allowed enum.

Steps to reproduce the behavior:

  1. Create a workflow requiring deployment approval (using the deployment protection rules). See https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#deployment-protection-rules
  2. Run the workflow
  3. Don't approve the run
  4. Start the gitactionboard
  5. Access the gitactionboard
  6. Check the error log in docker
  7. Caused by: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type de.otto.platform.gitactionboard.adapters.service.job.RunStatus from String "waiting": not one of the values accepted for Enum class: [queued, in_progress, completed]
  8. Check the workflow status in Github, it is set to "waiting"
  9. Check the gitactionboard source code, backend/src/main/java/de/otto/platform/gitactionboard/adapters/service/job/RunStatus.java, waiting is not part of the enum

Expected behavior
Support for the "waiting" workflow status, but ideally all statuses as listed on https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 18, 2023

Thanks for opening your first issue here! Be sure to follow the issue template!

@sumanmaity1234
Copy link
Collaborator

Got fixed as part of v3.3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants