-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-5977 Hide "Approve All Unreviewed Comments" button from admins on works #4966
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Jake, and thanks for the pull request!
I've left a review comment, and while there's already a test in features/admins/admin_post_news.feature that checks that the button is visible on news posts, we'd appreciate it if you could add a test to features/admins/admin_works.feature that ensures the button isn't visible on works.
I've assigned the Jira issue to you and set its status to In Review so no one will mistakenly create a duplicate pull request. I've also given your account permission to comment on, assign, and transition issues in the future.
Thanks again for contributing! If you have any questions, you can contact us at otw-coders@transformativeworks.org.
c4f194a
to
2216395
Compare
Test added, threw in a check for the per-comment "Approve" button as well, since I don't see it anywhere else. Used the helper, and decided to let it hide the button on works with no unreviewed comments as well, since the button would do nothing in that case. |
… works Also hides "Approve All Unreviewed Comments" when there are no unreviewed comments.
2216395
to
c96ba24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Issue
https://otwarchive.atlassian.net/browse/AO3-5977
Purpose
Hides the "Approve All Unreviewed Comments" button if an admin is viewing a work with comment moderation turned on.
Credit
Jake Faulkner