Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5843 change Invite Requests browser page title to Invitation Requests #5007

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

jeslynsee
Copy link
Contributor

… Requests

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-5843

Purpose

This changes and updates the browser page title from Invite Requests to Invitation Requests on the Invitation Requests page.

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If "Invitation Requests" page is rendered, browser title page should display "Invitation Requests | Archive Of Our Own" instead of "Invite Requests | Archive Of Our Own".

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

Jeslyn See (she/her)

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Jeslyn, and thanks for the pull request!

Just a couple comments from me. It looks like you already have a Jira account which is assigned to the issue; feel free to reply here or contact us at otw-coders@transformativeworks.org if you have any questions.

Thanks again for contributing!

app/controllers/invite_requests_controller.rb Outdated Show resolved Hide resolved
config/locales/controllers/en.yml Outdated Show resolved Hide resolved
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brianjaustin brianjaustin merged commit e785293 into otwcode:master Dec 31, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants