Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create subproject oof, a thin argparsing lib #12

Merged
merged 8 commits into from
Apr 5, 2021
Merged

Create subproject oof, a thin argparsing lib #12

merged 8 commits into from
Apr 5, 2021

Conversation

marcospb19
Copy link
Member

@marcospb19 marcospb19 commented Apr 4, 2021 •
edited
Loading

Replacing clap by oof decreased our binary size by 400KB.
Refactored a huge part of the codebase.

@marcospb19
Create subproject oof, a thin argparsing lib
9fb48fd 
And added it to the same workspace
@marcospb19 marcospb19 mentioned this pull request Apr 4, 2021
Closed
@marcospb19 marcospb19 requested a review from vrmiguel April 5, 2021 02:28
vrmiguel
vrmiguel approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@vrmiguel vrmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ☆ ☆ ☆

@vrmiguel vrmiguel merged commit 9796bd3 into master Apr 5, 2021
@vrmiguel vrmiguel deleted the oof-argparsing branch April 6, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrmiguel vrmiguel vrmiguel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcospb19 @vrmiguel