Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long messages in the progress bar #214

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Dec 7, 2021

Currently if the path is too long the progress bar wraps around, and starts spamming messages in new lines.

By using, wide_msg, long messages are automatically truncated by indicatf.

@marcospb19
Copy link
Member

There's something weird going on

image

image

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 8, 2021

Can you upload the file you're using because I can't reproduce this behavior.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 8, 2021

Aside: I just noticed something, ouch fails to compress if a directory contains a broken symlink

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 8, 2021

Also which terminal are you using?

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 8, 2021

I can reproduce, I'll see if I can figure it out

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 8, 2021

I think it should be fixed now

@marcospb19
Copy link
Member

I'll run some more manual tests before merging.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Dec 9, 2021

I noticed that paths that are printed when extracting from zip or tar are canonicalized, I think we need another pr to fix that which would improve the ux even more.

@marcospb19 marcospb19 changed the title Trancuate long messages in the progress bar Truncate long messages in the progress bar Dec 14, 2021
@marcospb19 marcospb19 merged commit a3d3e5d into ouch-org:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants