Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add further testing to oof #27

Merged
merged 7 commits into from
May 24, 2021
Merged

Add further testing to oof #27

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e11a99
Add unknown short flag test
May 18, 2021
dbb3293
add pre test setup function
May 18, 2021
5e7ee4f
Removing lifetime from OofError
marcospb19 May 19, 2021
f203b80
Fixing ouch OofError convertion
marcospb19 May 19, 2021
c057d9c
add further flag testing to oof crate
May 20, 2021
67bd239
fix test asserts to properly match error variants. add misplaced flag…
May 21, 2021
1059ba0
test every OofError variant done
May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions oof/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,19 @@ mod tests {
assert!(!flags.is_present("output_file"));
}

#[test]
fn test_unknown_short_flag() {
let flags_info = [
ArgFlag::long("output_file").short('o'),
Flag::long("verbose").short('v'),
Flag::long("help").short('h'),
];

let args = gen_args("ouch a.zip -s b.tar.gz");
let result = filter_flags(args, &flags_info).unwrap_err();
assert!(matches!(result, OofError::UnknownShortFlag('s')));
marcospb19 marked this conversation as resolved.
Show resolved Hide resolved
}

#[test]
fn test_pop_subcommand() {
let subcommands = &["commit", "add", "push", "remote"];
Expand Down