Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect file permissions when compressing zip files #271

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Sep 1, 2022

Only tested on linux

on unix platforms: keeps file permissions

on non-unix platforms: sets unix permissions to 755 if the file is executable (I'm not sure if I should keep this because iirc ouch doesn't respect permissions when decompressing zip files on non-unix platforms)

@marcospb19
Copy link
Member

So, I have been thinking about dropping non-unix (and Windows) support just because I, @vrmiguel, and most other developers cannot test and ensure everything is working there.

I also think that all Ouch's users are using unix anyways.

What do you think @vrmiguel?

@figsoda
Copy link
Member Author

figsoda commented Sep 15, 2022

any updates on this?

@marcospb19
Copy link
Member

Thanks for the ping, I spoke to Vrmiguel and we both agreed on dropping Windows support.

I think this PR can be merged as is and then I can create a new issue for dropping the support as a whole, what do you think?

@figsoda
Copy link
Member Author

figsoda commented Sep 16, 2022

I would be a little hesitant on completely dropping Window support, but I think we could official drop support for Windows and still make it compile on Windows.

We can merge this and get more opinions on this in a new issue.

@marcospb19 marcospb19 merged commit 398a619 into ouch-org:main Sep 16, 2022
@marcospb19 marcospb19 mentioned this pull request Sep 16, 2022
@figsoda figsoda deleted the zip-permissions branch September 16, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants