Warn user if file extension is passed as file name #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch name was supposed to be |
figsoda
reviewed
Oct 11, 2022
figsoda
reviewed
Oct 11, 2022
|
Unrelated to this, but using split might have some performance gain over what we have right now, especially when we have to do |
Yeah, but in the context of compressing and decompressing files, I think that the performance gain from parsing the path is negligible (this also runs only for CLI given args I think). |
example: .tar.gz is a file named .tar with extension .gz this can be confusing because people might expect .tar.gz to be a .tar.gz archive, but it's currently not
marcospb19
force-pushed
the
wann-file-extension-passed-as-file-name
branch
from
18cc40a
to
4f0839f
Compare
figsoda
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example:
.tar.gzis a file named .tar with extension.gzthis can be confusing because people might expect a
path
'.tar.gz'to be a.tar.gzarchive, but it's not