Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite progress module #280

Merged
merged 6 commits into from
Oct 13, 2022
Merged

rewrite progress module #280

merged 6 commits into from
Oct 13, 2022

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Oct 12, 2022

  • removes all remaining uses of unsafe
  • no more mpsc channels
  • no more display handle abstractions
  • less passing around functions

this should behave the same as before, but I haven't extensively tested it, mostly been relying on the integration tests

marcospb19
marcospb19 requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@marcospb19 marcospb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a huge improvement in code quality, it's much much simpler now.

Code is amazing, just one nitpick:

src/archive/zip.rs Outdated Show resolved Hide resolved
@marcospb19 marcospb19 merged commit 385a630 into ouch-org:main Oct 13, 2022
@figsoda figsoda deleted the rewrite-progress branch October 13, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospb19 marcospb19 marcospb19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@figsoda @marcospb19