Remove automatic detection for partial compression #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285 and fixes #282 with a feature regression.
What is the problem this feature used to solve?
Ouch infers compression formats from file extensions.
From the output file, Ouch infers the formats
[Tar, Gz]
.However, sometimes you want to compress a file that is already compressed, for example:
Again, Ouch infers the formats
[Tar, Gz]
and compressesfile.tar
with these formats in mind, this is a problem because the end result is an archive of type[Tar, Tar, Gz]
.Ouch should, in some way, enable the user to compress this just using
[Gz]
(I'm calling thispartial compression
, because the archive is already partially compressed).The feature
I implemented (with the code removed by this PR) a tiny automatic detection for when formats match.
Problems with automatic detection:
stdout
andstdin
, because those aren't named.Solution
Regress this feature and implement
--format
flag.