Update README and and docs #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the readme, update line 5 to the following:
|
|
Hi Erik, unfortunately I have another update to the copy. Here is the new one:
|
ligustah
approved these changes
Apr 25, 2024
|
|
||
| ``` | ||
| chain_id: u64 -- filter by chain id | ||
| kind: String, -- filter by kind (zora_v2) |
There was a problem hiding this comment.
Not really related to this change, but was just wondering if the kind should also be used in the JSON payloads? Currently it's zoraV2 in JSON and zora_v2 in the filter.
There was a problem hiding this comment.
likely yes, the key right now is derived from the serde of the PremintTypes enum, we could actually choose to go keyless and just have the message be top level, or we can override the enum serde label to be the same as kind
erikreppel
force-pushed
the
erik/back-2756-code-docs-and-readme
branch
from
6bc06d7
to
4c3bcfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.