Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is service_msgs added as a dependency? #113

Closed
Aposhian opened this issue Apr 28, 2023 · 2 comments
Closed

Why is service_msgs added as a dependency? #113

Aposhian opened this issue Apr 28, 2023 · 2 comments
Assignees
@Samahu
Labels
question Further information is requested

Comments

@Aposhian
Copy link

Describe your question
Why is service_msgs being pulled in as a dependency when it isn't being used? This package is only released on rolling, not even on humble, so it makes building on ROS LTS a little harder than it needs to be.
@Aposhian Aposhian added the question Further information is requested label Apr 28, 2023
@Samahu Samahu self-assigned this Apr 28, 2023
@Samahu
Copy link
Contributor

Samahu commented Apr 29, 2023

The short answer, I am not sure. I probably added it because a PR I was working on failed during the build. I will open another pull request to check if is still required.

This was referenced Apr 29, 2023
Merged
Merged
@Samahu
Copy link
Contributor

Samahu commented Apr 30, 2023

service_msgs removed as a dependency

@Samahu Samahu closed this as completed Apr 30, 2023
tobii-ho pushed a commit to StarkStrom-Driverless/ouster-ros that referenced this issue Dec 27, 2023
@Krishtof-Korda
Ez/readme improvement (ouster-lidar#113)
5a47c48 
Change OS-1 to OS1 throughout and clean up links

Submitted on behalf of @emily-zhang
tobii-ho pushed a commit to StarkStrom-Driverless/ouster-ros that referenced this issue Jan 23, 2024
@Krishtof-Korda
ouster-ros Ez/readme improvement (ouster-lidar#113)
f6dc6ee 
Change OS-1 to OS1 throughout and clean up links

Submitted on behalf of @emily-zhang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Samahu Samahu

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Samahu @Aposhian