feat(wip): check CI #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
outSH
force-pushed
the
esm_ci_check
branch
3 times, most recently
from
55d7be0
to
c3ab1ae
Compare
- Change all relative path imports to have `.js` suffix required by the
ESM standard.
- Use full import path instead of directory default import.
- I've created a tool for doing this automatically (existing tools were
failing on some edge cases). The sources
are available here: https://github.com/outSH/to-esm-imports.
- The tool is executed after codegen (because openapi generators
doesn't support creating ESM-compatible imports yet).
- Changed jest and webpack configs to work with
fully qualified ESM imports.
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.