Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

test(gql): Clean up facets and rdf tests. #17

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Mar 11, 2022

Fix tests in the gql package.

  • Remove tests for NQuad/RDF parsing
  • Remove existing facets tests
  • Add test for "facets are not supported" error

This change is Reviewable

Fix tests in the gql package.

* Remove tests for NQuad/RDF parsing
* Remove existing facets tests
* Add test for "facets are not supported" error
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks, @danielmai !

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danielmai)

@danielmai danielmai merged commit 52494b9 into main Mar 11, 2022
@danielmai danielmai deleted the danielmai/fix-gql-tests branch March 14, 2022 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants