This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
feat(Upsert): Upsert from within Raft loop #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to query for and determine the UID for a node, based on its XIDs (external IDs) within the Raft loop. It does so by figuring out which predicates constitute the XID, and adding those in a new
NewObjects
struct within Mutations.This would ensure that concurrent upserts do not end up creating duplicate nodes. Raft loop serializes all the writes. Whichever upsert comes first would create the node. The second upsert would then be able to query the created node and reuse it, without failing. This is a better mechanism than doing optimistic transactions which would have resulted in aborts.
This PR also consolidates a bunch of things into one:
Essentially, it consolidates the type conversion and mutation structs, introduced in 2016, into simplified structures. Hence eliminating a lot of roundabout complexity gained over time.
This change is