-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage with Vitest #71
Comments
/bounty $250 |
💎 $250 bounty • Outerbase (YC W23)Steps to solve:
Thank you for contributing to outerbase/starbasedb! Add a bounty • Share on socials
|
/attempt #71
|
/attempt #71
|
@Brayden There are a few bugs in implementations that are getting found during tests. I am fixing them too along with the testing. Could I draft PR? |
💡 @aybanda submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
You may absolutely fix issues along the way. Feel free to draft a PR @varshith257! |
@Brayden I have opened and fixing few more implementations caught in the way in testing |
💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
Is your feature request related to a problem? Please describe.
Currently the test coverage of the project is nearly non-existent. We do have and use Vitest as a dependency in the Starbase project already that future tests should also use. The idea is to begin accumulating test coverage throughout the entire project.
Goal is to bring test coverage up to above 75% with meaningful tests.
Describe the solution you'd like
Important: Tests should not just be made for line coverage, they should also include meaningful tests that help reveal when issues arise. For example, if we were to write a test for our LiteREST code to see if making a request fetched data we would pass it potentially:
-1
ornull
as a valueWhen PR's are made we run the following Github test action (https://github.com/outerbase/starbasedb/blob/main/.github/workflows/test.yaml) that verifies the project can execute a
pnpm i
and then run tests withpnpm test
. All tests added should be executed during that samepnpm test
command.Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: