Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage with Vitest #71

Open
Brayden opened this issue Jan 23, 2025 · 9 comments
Open

Improve test coverage with Vitest #71

Brayden opened this issue Jan 23, 2025 · 9 comments
Labels
💎 Bounty enhancement New feature or request

Comments

@Brayden
Copy link
Member

Brayden commented Jan 23, 2025

Is your feature request related to a problem? Please describe.
Currently the test coverage of the project is nearly non-existent. We do have and use Vitest as a dependency in the Starbase project already that future tests should also use. The idea is to begin accumulating test coverage throughout the entire project.

Goal is to bring test coverage up to above 75% with meaningful tests.

Describe the solution you'd like
Important: Tests should not just be made for line coverage, they should also include meaningful tests that help reveal when issues arise. For example, if we were to write a test for our LiteREST code to see if making a request fetched data we would pass it potentially:

  • a real table name
  • a fake table name
  • no table name (omitted altogether)
  • -1 or null as a value

When PR's are made we run the following Github test action (https://github.com/outerbase/starbasedb/blob/main/.github/workflows/test.yaml) that verifies the project can execute a pnpm i and then run tests with pnpm test. All tests added should be executed during that same pnpm test command.

Describe alternatives you've considered
N/A

Additional context
N/A

@Brayden Brayden added the enhancement New feature or request label Jan 23, 2025
@Brayden
Copy link
Member Author

Brayden commented Jan 24, 2025

/bounty $250

Copy link

algora-pbc bot commented Jan 24, 2025

💎 $250 bounty • Outerbase (YC W23)

Steps to solve:

  1. Start working: Comment /attempt #71 with your implementation plan
  2. Submit work: Create a pull request including /claim #71 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to outerbase/starbasedb!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @varshith257 Jan 24, 2025, 4:26:08 PM #74
🟢 @aybanda Jan 24, 2025, 6:00:30 PM #73

@varshith257
Copy link

varshith257 commented Jan 24, 2025

/attempt #71

Algora profile Completed bounties Tech Active attempts Options
@varshith257 25 bounties from 11 projects
Scala, Rust,
TypeScript & more
Cancel attempt

@aybanda
Copy link

aybanda commented Jan 24, 2025

/attempt #71

Algora profile Completed bounties Tech Active attempts Options
@aybanda 2 bounties from 2 projects
TypeScript, Python,
Julia & more
Cancel attempt

@varshith257
Copy link

@Brayden There are a few bugs in implementations that are getting found during tests. I am fixing them too along with the testing. Could I draft PR?

Copy link

algora-pbc bot commented Jan 24, 2025

💡 @aybanda submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@Brayden
Copy link
Member Author

Brayden commented Jan 24, 2025

@Brayden There are a few bugs in implementations that are getting found during tests. I am fixing them too along with the testing. Could I draft PR?

You may absolutely fix issues along the way. Feel free to draft a PR @varshith257!

@varshith257
Copy link

varshith257 commented Jan 24, 2025

@Brayden I have opened

and fixing few more implementations caught in the way in testing

Copy link

algora-pbc bot commented Jan 24, 2025

💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants