Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Update - default value for with_public_ip and export outputs from metaflow module #69

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

josephsirak
Copy link
Contributor

@josephsirak josephsirak commented Jul 11, 2023

Update docs:

  1. Set the with_public_ip value in the README to true since the code already sets the public subnets
  2. Export outputs from metaflow module to the top level project in the minimal setup example. Output:
+ metaflow = {
      + METAFLOW_BATCH_JOB_QUEUE                    = (known after apply)
      + METAFLOW_DATASTORE_SYSROOT_S3               = (known after apply)
      + METAFLOW_DATATOOLS_S3ROOT                   = (known after apply)
      + METAFLOW_ECS_S3_ACCESS_IAM_ROLE             = (known after apply)
      + METAFLOW_EVENTS_SFN_ACCESS_IAM_ROLE         = (known after apply)
      + METAFLOW_SERVICE_INTERNAL_URL               = (known after apply)
      + METAFLOW_SERVICE_URL                        = (known after apply)
      + METAFLOW_SFN_DYNAMO_DB_TABLE                = (known after apply)
      + METAFLOW_SFN_IAM_ROLE                       = (known after apply)
      + api_gateway_rest_api_id_key_id              = (known after apply)
      + batch_compute_environment_security_group_id = (known after apply)
      + datastore_s3_bucket_kms_key_arn             = (known after apply)
      + metadata_svc_ecs_task_role_arn              = (known after apply)
      + metaflow_api_gateway_rest_api_id            = (known after apply)
      + metaflow_batch_container_image              = ""
      + metaflow_profile_json                       = (known after apply)
      + metaflow_s3_bucket_arn                      = (known after apply)
      + metaflow_s3_bucket_name                     = (known after apply)
      + migration_function_arn                      = (known after apply)
      + ui_alb_arn                                  = (known after apply)
      + ui_alb_dns_name                             = (known after apply)
    }

@josephsirak josephsirak marked this pull request as ready for review July 11, 2023 20:31
This change exports all outputs from the metaflow module which are values needed to configure metaflow.
@josephsirak josephsirak merged commit 40eb571 into master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants