Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @JvmField to TypeName constants #15

Closed
wants to merge 5 commits into from
Closed

Conversation

arouel
Copy link

@arouel arouel commented Jul 28, 2022

What

  • Add @JvmField to TypeName constants
  • Update Kotlin to 1.7.10
  • Update JaCoCo to 0.8.7
  • Update Guava to 31.1-jre
  • Set release version to 1.1.3

Why

  • Let the Kotlin compiler know that we want to expose constants like TypeName.NUMBER as a static field in the Java representation.
  • Get the project running with OpenJDK 11.
  • Benefit from bug fixes and improvements of a recent Kotlin version.

arouel added 3 commits July 28, 2022 15:22
Let the Kotlin compiler know that we want to expose constants like `TypeName.NUMBER` as a static field in Java.
@arouel arouel changed the title Update Kotlin to 1.7.10 Add @JvmField to TypeName constants Jul 28, 2022
@kdubb
Copy link
Contributor

kdubb commented Jul 29, 2022

These should be separate PRs

@kdubb
Copy link
Contributor

kdubb commented Jul 29, 2022

And you should not change the release version. That only happens when a release is made.

@arouel
Copy link
Author

arouel commented Jul 29, 2022

I will create separate PRs. Thank you for the feedback.

@arouel
Copy link
Author

arouel commented Sep 8, 2022

@kdubb I close this PR in favor of
#17
#18
#19
#20

@arouel arouel closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants