Fixed sunspot-solr stop - kill child processes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I'm experiencing this problem running stop through bundle as well: leaves the java process alive. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run globally (without bundle)
then java process with solr program is not killed properly and it still exists in processes list.
By running:
you can see that there are two processes created:
Following command:
kills only the parent process (sh) and java process is still runing:
konrad 3304 2.4 2.3 1148712 69708 ? Sl 11:32 0:03 java -Dsolr.data.dir=/tmp -Dsolr.solr.home=/home/konrad/.rvm/gems/ruby-1.9.3-p194/gems/sunspot_solr-1.3.3/solr/solr -jar start.jarThis commit fixes this problem. Now sunspot-solr stop command kills also all child processes of process which pid was saved.