Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable pinning of typescript via "resolutions" #33

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

levino
Copy link
Contributor

@levino levino commented Nov 17, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

⚠️ No Changeset found

Latest commit: f9def0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@levino
Copy link
Contributor Author

levino commented Nov 17, 2022

I am not sure if yarn would have suffered from the same problems when typescript were no root dependency. Might or might not be the case.

@shubham-kaushal shubham-kaushal merged commit 0a91411 into outpostHQ:migrate-to-parcel Nov 17, 2022
@shubham-kaushal
Copy link
Member

I am not sure if yarn would have suffered from the same problems when typescript were no root dependency. Might or might not be the case.

I'll try to check with yarn as well to confirm.

@shubham-kaushal
Copy link
Member

shubham-kaushal commented Nov 17, 2022

image
@levino Thanks for your help!🙏 Builds are working fine now. However, it looks like Tree Shaking and Code Splitting is not working properly. The bundle size is big. I am releasing a dev version now to cross-check, will update you.

@shubham-kaushal
Copy link
Member

shubham-kaushal commented Nov 17, 2022

The bundle size with the parcel ---- which should reduce further to 12kb minified, currently it's 36kb minified
https://bundlephobia.com/package/tastycss@0.0.0-dev-20221117103514

@levino
Copy link
Contributor Author

levino commented Nov 17, 2022

I have no idea why you wanted to use parcel in the first place. I am just a random passer by who had parcel-bundler/parcel#8419 and found a workaround after @devongovett did not like my fix. Since you were unable to use the workaround to get parcel running, I helped you. I cannot say if the bundle size is small or large. That is another question / issue you need to raise with parcel.

@shubham-kaushal shubham-kaushal mentioned this pull request Nov 17, 2022
@shubham-kaushal
Copy link
Member

Sorry, I thought you are one of the team members of the parcel team.

I was using tsup which is using esbuild under the hood and was facing tree-shaking issues in our both TastyCSS and Jenga UI library, especially with Jenga UI, more. tsup is good but it lacks community and support, I tried everything recommended in tsup doc https://tsup.egoist.dev/#tree-shaking but it didn't solve the issue of tree shaking in Jenga UI.

So, thought of trying parcel after looking at this comparison https://github.com/devongovett/parcel-vs-vite-vs-turbopack-hmr and doc https://parceljs.org/features/production/

Thanks again for your help! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants