Skip to content

Commit

Permalink
Drop ARM softfp bot
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=242236

Reviewed by Aakash Jain.

The softfp ARMv7 bot has been kept around to ensure that things would
work for users that are depend on vendor libraries that require the
softfp ABI. Recent changes broke softfp and we're no longer aware of any
users for it. Bug 242172 drops JSC support for the softfp ABI; this bug
is about removing the corresponding buildbot from build.webkit.org.

* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

Canonical link: https://commits.webkit.org/252115@main
  • Loading branch information
aoikonomopoulos authored and Jarred-Sumner committed Jul 27, 2022
1 parent f75b595 commit fd5fb72
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 19 deletions.
8 changes: 1 addition & 7 deletions Tools/CISupport/build-webkit-org/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
{ "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
{ "name": "jsconly-linux-igalia-bot-3", "platform": "jsc-only" },
{ "name": "jsconly-linux-igalia-bot-4", "platform": "jsc-only" },
{ "name": "jsconly-linux-igalia-bot-5", "platform": "jsc-only" },

{ "name": "wpe-linux-bot-1", "platform": "wpe" },
{ "name": "wpe-linux-bot-2", "platform": "wpe" },
Expand Down Expand Up @@ -561,11 +560,6 @@
"platform": "jsc-only", "configuration": "release", "architectures": ["armv7"],
"workernames": ["jsconly-linux-igalia-bot-3"]
},
{
"name": "JSCOnly-Linux-ARMv7-Thumb2-SoftFP-Release", "factory": "BuildAndJSCTestsFactory",
"platform": "jsc-only", "configuration": "release", "architectures": ["armv7"],
"workernames": ["jsconly-linux-igalia-bot-5"]
},
{
"name": "JSCOnly-Linux-MIPS32el-Release", "factory": "BuildAndJSCTestsFactory",
"platform": "jsc-only", "configuration": "release", "architectures": ["mips"],
Expand Down Expand Up @@ -649,7 +643,7 @@
"WPE-Linux-64-bit-Release-Ubuntu-2004-Build",
"WPE-Linux-64-bit-Release-Ubuntu-LTS-Build",
"JSCOnly-Linux-AArch64-Release",
"JSCOnly-Linux-ARMv7-Thumb2-Release", "JSCOnly-Linux-ARMv7-Thumb2-SoftFP-Release",
"JSCOnly-Linux-ARMv7-Thumb2-Release",
"JSCOnly-Linux-MIPS32el-Release", "PlayStation-Release-Build", "PlayStation-Debug-Build",
"WinCairo-64-bit-WKL-Release-Build", "WinCairo-64-bit-WKL-Debug-Build",
"WPE-Linux-64-bit-Release-Build", "WPE-Linux-64-bit-Debug-Build",
Expand Down
11 changes: 0 additions & 11 deletions Tools/CISupport/build-webkit-org/factories_unittest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1461,17 +1461,6 @@ class TestExpectedBuildSteps(unittest.TestCase):
'compile-webkit',
'jscore-test'
],
'JSCOnly-Linux-ARMv7-Thumb2-SoftFP-Release': [
'configure-build',
'configuration',
'clean-and-update-working-directory',
'checkout-specific-revision',
'show-identifier',
'delete-WebKitBuild-directory',
'delete-stale-build-files',
'compile-webkit',
'jscore-test'
],
'JSCOnly-Linux-MIPS32el-Release': [
'configure-build',
'configuration',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ WebKitBuildbot = function()
}},
"JSCOnly ARMv7 Testers": {platform: Dashboard.Platform.LinuxJSCOnly, heading: "ARMv7", combinedQueues: {
"JSCOnly-Linux-ARMv7-Thumb2-Release": {heading: "ARMv7 Thumb2"},
"JSCOnly-Linux-ARMv7-Thumb2-SoftFP-Release": {heading: "ARMv7 Thumb2 SoftFP"},
}},
"JSCOnly MIPS Testers": {platform: Dashboard.Platform.LinuxJSCOnly, heading: "MIPS", combinedQueues: {
"JSCOnly-Linux-MIPS32el-Release": {heading: "MIPS32el"},
Expand Down

0 comments on commit fd5fb72

Please sign in to comment.