Support reading from .npmrc #11979
Support reading from .npmrc #11979
Conversation
|
❌ @Jarred-Sumner, your commit has failing tests :( 🪟💻 3 failing tests Windows x64 baseline
🪟💻 3 failing tests Windows x64
|
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -37,6 +38,7 @@ extern "C" JSPropertyIterator* Bun__JSPropertyIterator__create(JSC::JSGlobalObje | |||
| JSC::VM& vm = globalObject->vm(); | |||
| JSC::JSValue value = JSValue::decode(encodedValue); | |||
| JSC::JSObject* object = value.getObject(); | |||
| ASSERT(object != NULL); | |||
There was a problem hiding this comment.
This assertion doesn't do anything, getObject() will crash before this line is reached if that assertion wasn't true
There was a problem hiding this comment.
The implementation of getObject() is this which returns a null pointer
inline JSObject* JSValue::getObject() const
{
return isCell() ? asCell()->getObject() : nullptr;
}There was a problem hiding this comment.
isCell() when given a null pointer returns true (yes, surprising)
asCell()->getObject() then de-references the null pointer and 💥
| return error.ParserError; | ||
| } | ||
|
|
||
| // if (!bun.Environment.isDebug) { |
There was a problem hiding this comment.
is there a reason this is not deleted?
| } | ||
|
|
||
| const had_errors = log.hasErrors(); | ||
| log.printForLogLevel(Output.errorWriter()) catch bun.outOfMemory(); |
There was a problem hiding this comment.
why are we printing here instead of in the caller?
| }); | ||
| } | ||
|
|
||
| // await makeTest([["_authToken", "skibidi"]], result => { |
There was a problem hiding this comment.
Why is this commented out? Should it be deleted or should it be uncommented?
| Global.exit(1); | ||
| }, | ||
| } | ||
| const source = bun.logger.Source.initPathString(".npmrc", npmrc_contents.items[0..]); |
There was a problem hiding this comment.
Is there a reason we have another implementation of reading a file from disk, instead of using bun.sys.File.toSource or bun.sys.File.toSourceAt?
| }; | ||
| } | ||
| } | ||
| return .none; |
There was a problem hiding this comment.
the only return thats necessary is the last one right?
|
@zackradisic looks like the test failures in bun-install-registry are real |
|
This should be updated. |
There was a problem hiding this comment.
Are public-hoist-pattern, legacy-peer-deps planned?
legacy-peer-deps would roughly correspond to peer = false with this caveat:
What does this PR do?
WIP
This PR implements a .npmrc parser and loads it with Bun's package manager
Fixes #643