New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export syntax error fix for exported enums and namespaces #1203

Merged

Jarred-Sumner merged 1 commit into oven-sh:main from dylan-conway:fix-syntax-error-for-exported-enum

Sep 3, 2022

Member

dylan-conway commented Sep 3, 2022

Removed setting is_export for variables used inside generated closures for enums and namespaces. Can be seen in esbuild as well: https://github.com/evanw/esbuild/blob/77194c8fd8026e8e9f09f4480d1be42aaa6fc09c/internal/js_parser/ts_parser.go#L1627

Fixes #1136


          fixed is_export and added test cases

90e0e7f

github-actions bot added packages:bun needs tests labels

Jarred-Sumner merged commit 8b2d07e into oven-sh:main

Collaborator

Jarred-Sumner commented Sep 3, 2022

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels