Clean up error codes in napi somewhat #13179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit 8ec6a1c has 8 failures in test/cli/watch/watch.test.ts - timeout on 🪟 x64-baselinetest/cli/watch/watch.test.ts - timeout on 🪟 x64test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baselinetest/cli/hot/watch.test.ts - 1 failing on 🪟 x64test/js/bun/jsc/bun-jsc.test.ts - timeout on 🪟 x64-baselinetest/js/bun/jsc/bun-jsc.test.ts - timeout on 🪟 x64test/cli/hot/hot.test.ts - 3 failing on 🪟 x64-baselinetest/cli/hot/hot.test.ts - 3 failing on 🪟 x64test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baselinetest/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64-baselinetest/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64test/regression/issue/07500/07500.test.ts - 1 failing on 🪟 x64-baseline |
|
@Jarred-Sumner, % Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
13 372M 13 50.4M 0 0 40.5M 0 0:00:09 0:00:01 0:00:08 50.6M
34 372M 34 127M 0 0 56.9M 0 0:00:06 0:00:02 0:00:04 64.0M
53 372M 53 199M 0 0 61.6M 0 0:00:06 0:00:03 0:00:03 66.7M
72 372M 72 270M 0 0 63.6M 0 0:00:05 0:00:04 0:00:01 67.5M
92 372M 92 346M 0 0 66.0M 0 0:00:05 0:00:05 --:--:-- 69.2M
100 372M 100 372M 0 0 66.8M 0 0:00:05 0:00:05 --:--:-- 74.4MCommit: 8ec6a1c |
190n
reviewed
Aug 9, 2024
src/bun.js/bindings/napi.cpp
Outdated
Comment on lines
1234
to
1243
| if (catchScope.exception()) { | ||
| catchScope.clearException(); | ||
| return {}; | ||
| } | ||
| } | ||
|
|
||
| if (catchScope.exception()) { | ||
| catchScope.clearException(); | ||
| return {}; | ||
| } |
There was a problem hiding this comment.
I think so. This check should be deleted because it looks like the one above would catch any exceptions
Jarred-Sumner
commented
Aug 13, 2024
Jarred-Sumner
commented
Aug 13, 2024
Jarred-Sumner
commented
Aug 13, 2024
Jarred-Sumner
commented
Aug 13, 2024
Jarred-Sumner
commented
Aug 13, 2024
src/bun.js/bindings/napi.cpp
Outdated
| } | ||
| *result = reinterpret_cast<napi_value>(error); | ||
|
|
There was a problem hiding this comment.
*result = toNapi(err);
Jarred-Sumner
commented
Aug 13, 2024
dylan-conway
approved these changes
Aug 13, 2024
190n
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clean up error codes in napi somewhat
How did you verify your code works?