Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and bug fixes in the V8 API #13754

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Refactoring and bug fixes in the V8 API #13754

wants to merge 31 commits into from

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    fe61bf6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3203542 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ef8346 View commit details
    Browse the repository at this point in the history
  4. Get rid of Map::boolean_map

    190n committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    151fcd6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1e0aef9 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Configuration menu
    Copy the full SHA
    e040644 View commit details
    Browse the repository at this point in the history
  2. Delete v8::Roots and move its contents into v8::Isolate, and perform …

    …the necessary refactoring
    190n committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    86d3a24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7335a07 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Use m_ for all fields

    190n committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0d47d2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cba2a95 View commit details
    Browse the repository at this point in the history
  3. Move Bun-specific V8 classes into namespace v8::shim

    The v8 namespace was confusingly polluted with both classes that exist
    in the actual V8 API, as well as new classes to support Bun's specific
    implementation of that API. This commit moves the latter into the
    namespace v8::shim. It also makes a duplicate of classes with fields in
    the v8::shim namespace. For those classes, the v8:: version has no
    fields, no JSC superclass, and only implements the actual V8 API
    functions, while the v8::shim:: version has the inheritance and
    functions necessary to be allocated as a JSC object and implements
    helper functions to support the V8 APIs.
    190n committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e2ed8ea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    64b3aea View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Delete v8::Data::localToPointer

    190n committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5177532 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4e365c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7790d2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6d9ec16 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6efb86a View commit details
    Browse the repository at this point in the history
  6. Clean up roots handling

    190n committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    87d4add View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cd71965 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    2033a30 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3358383 View commit details
    Browse the repository at this point in the history
  3. Fix GlobalInternals type info

    190n committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f2d76b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    017aacc View commit details
    Browse the repository at this point in the history
  2. Fix build error

    190n committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f0a9081 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    8c60f2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f1ddb4 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    08a3ffd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f3086a View commit details
    Browse the repository at this point in the history
  3. Use it.skipIf for uv_os_* tests

    190n committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d677083 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bfd58e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    758a993 View commit details
    Browse the repository at this point in the history