feat(webcrypto): Implement X25519 key derivation #13798
Draft
+345
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I need help finishing this PR, since my knowledge of C/C++ is limited.
⚠️ Currently the build is failing
This PR implements X25519 key derivation in the webcrypto module. It introduces a new algorithm identifier for X25519, updates the relevant classes and methods to support key generation, derivation, import, and export for this algorithm.
With this algorithm it will unblock to use https://github.com/WhiskeySockets/Baileys Whatsapp library
Key Changes:
Added X25519 to CryptoAlgorithmIdentifierTag and CryptoAlgorithmIdentifier.
Implemented the CryptoAlgorithmX25519 class with methods for key generation, derivation, import, and export (From Webkit)
Updated the SubtleCrypto class to recognize and handle the new X25519 algorithm.
Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes
Fixes:
How did you verify your code works?