Experiment: Add buffer type and inline pointer
#14036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit c9cca19 has 7 failures in test/js/node/watch/fs.watch.test.ts - 1 failing on 🍎 14 x64test/js/node/test/parallel/fs-watch-recursive-add-folder.test.js - 1 failing on 🍎 14 aarch64test/integration/next-pages/test/dev-server-ssr-100.test.ts - timeout on 🍎 14 aarch64test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64test/cli/hot/watch.test.ts - 1 failing on 🪟 x64test/cli/watch/watch.test.ts - 2 failing on 🪟 x64test/js/bun/http/bun-serve-static.test.ts - 2 failing on 🍎 13 aarch64 |
190n
reviewed
Sep 20, 2024
| @@ -2064,7 +2080,7 @@ pub const FFI = struct { | |||
| function = 17, | |||
| napi_env = 18, | |||
| napi_value = 19, | |||
|
|
|||
| buffer = 20, | |||
| pub const max = @intFromEnum(ABIType.napi_value); | |||
There was a problem hiding this comment.
should at least change to ABIType.buffer, or we can calculate the max:
Suggested change
| pub const max = @intFromEnum(ABIType.napi_value); | |
| pub const max = max_abi_type: { | |
| var current_max = std.math.minInt(i32); | |
| for (@typeInfo(ABIType).Enum.fields) |f| { | |
| current_max = @max(current_max, f.value); | |
| } | |
| break :max_abi_type current_max; | |
| }; |
or, could we @cImport these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?