Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 9395 #14815

Merged
merged 1 commit into from
Oct 26, 2024
Merged

fix 9395 #14815

merged 1 commit into from
Oct 26, 2024

Conversation

dylan-conway
Copy link
Collaborator

What does this PR do?

fixes #9395

How did you verify your code works?

added a test

@robobun
Copy link

robobun commented Oct 25, 2024

@dylan-conway, your commit 571b995 has 1 failures in #5291:

  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64-baseline
  • @Jarred-Sumner Jarred-Sumner merged commit 8727939 into main Oct 26, 2024
    42 of 44 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the dylan/undefined-encode branch October 26, 2024 02:58
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    TextEncoder.encode incorrectly encodes 'undefined'
    3 participants