-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --elide-lines override flag for workspace filtering #15837
Conversation
Might be nice to have this as a bunfig option as well, so it doesn't have to be included in every command. |
Nice. Looks like there's some test failures, but this is a good idea and I would like to merge it once the tests pass. |
@jakeboone02 sounds reasonable! I attempted to add it here https://github.com/oven-sh/bun/blob/main/src/bunfig.zig#L592 and it didn't do anything - happen to know why off the top of your head before I debug? @Jarred-Sumner awesome 🙏 which tests? looks like they're all passing in CICD afaict |
I don't know but be aware of #12216 (although that seems like the opposite problem...🤷♂️). |
I'm not sure why its green status, but if you press "details" it will send you to the page: https://buildkite.com/bun/bun/builds/8169 |
aha ty @RiskyMH should've clicked through. Fixed cc @Jarred-Sumner (2 fail on canary because my code isn't there yet I guess) @jakeboone02 I agree with you it'd be nice to have it in bunfig but unclear to me immediately why that isn't working like --silent.. Ok if we make that a follow-up PR when I have more cycles? |
Sure! The sooner the better for the CLI flag IMO. A bunfig option can wait. |
I woud like to merge this but there are Windows test failures |
ah-- I think it's because windowsIsTerminal() does not respect FORCE_COLOR which is how I trigger the code path in the other environments https://github.com/oven-sh/bun/blob/main/src/cli/filter_run.zig#L534 -- now if you try use it in a non TTY environment it'll error, and I explicitly test that on windows. Hopefully passes this time 😅 sorry! |
My goodness - I'm waiting for the merge. This is the most annoying thing about Bun-based monorepo |
Thank you. This will be part of Bun v1.1.43 |
What does this PR do?
This adds a new flag --elide-lines to bun test to allow overriding the default value of 10. Lots of other folks ran into this in #12431
How did you verify your code works?
Manually and via unit tests
before:
after:
The coupling of elide to pretty output was a little tight so my matching for the output is a little relaxed as a result and I had to make minor tweaks to the test runner to pass in the extra env flags