perf(node:util): fast path for extractedSplitNewLines
#15838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperclover
requested changes
Dec 19, 2024
There was a problem hiding this comment.
i think on my end, i should make the bindings generator pass WTFString instead of bun.String, since it will always be of the WTFStringImpl tag. this is significant because the input to this function is always latin1 or utf16, and never utf8. checking for the utf8 encoding in this function shouldn't be done since it wont ever be present.
added 2 commits
December 18, 2024 19:05
paperclover
approved these changes
Dec 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Co-authored-by: Don Isaac <don@bun.sh> Co-authored-by: DonIsaac <DonIsaac@users.noreply.github.com>
auto-merge was automatically disabled
December 19, 2024 23:58
Pull Request is not mergeable
probably-neb
pushed a commit
to probably-neb/bun
that referenced
this pull request
Jan 7, 2025
Co-authored-by: Don Isaac <don@bun.sh> Co-authored-by: DonIsaac <DonIsaac@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractedSplitNewLinesuses a regex with a positive lookahead to spit strings by newlines. Benchmarks show that this causesinspectto be ~2-3x slower than node when this codepath is hit. This PR adds a fast path when the object being split is known to be a string.We cannot run this fast path in all cases since splitting via a regexp respects
Symbol.split.