fix(install): peer/dev/optional = false lockfile fix
#15874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 1:02 AM PT - Dec 20th, 2024
✅ @Jarred-Sumner, your commit d84c9ea has passed in 🧪 try this PR locally: bunx bun-pr 15874 |
src/install/lockfile.zig
Outdated
| const trees = this.list.items(.tree); | ||
| const dependencies = this.list.items(.dependencies); | ||
|
|
||
| while (i < end) : (i += 1) { |
There was a problem hiding this comment.
Suggested change
| while (i < end) : (i += 1) { | |
| for (trees[i..end]) |*tree| { |
src/install/lockfile.zig
Outdated
| &pkg_metas[pkg_id], | ||
| )) { | ||
| if (log_level.isVerbose()) { | ||
| const meta = pkg_metas[pkg_id]; |
There was a problem hiding this comment.
Suggested change
| const meta = pkg_metas[pkg_id]; | |
| const meta = &pkg_metas[pkg_id]; |
Jarred-Sumner
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures the dependency tree saved to the lockfile includes dependencies that are disabled through configuration. This fixes bugs where your lockfile would fail to load due to it being unresolvable.
fixes #15858
Also fixes a crash caused by the lockfile containing an invalid url.
Implements
bun install --omit <dependency type>fordev,peer, andoptional.closes #5571
Adds support for
omitandincludein.npmrc.closes #15107
Fixes inconsistent total package install count in progress. Now it will report total number of package copies instead of unique packages.
fixes (unconfirmed) #15598
Fixes an infinite loop caused by disabling optional dependencies and installing with a populated cache.
How did you verify your code works?
Added a test for invalid url bug, --omit, and valid text lockfiles after disabling dependency groups.