Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add usage messages to check-node.sh #15885

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore: add usage messages to check-node.sh #15885

merged 1 commit into from
Dec 19, 2024

Conversation

DonIsaac
Copy link
Contributor

Makes check-node.sh easier to use for newcomers.

  1. -h,--help shows a usage message
  2. forgetting to pass a module name exits the script with an error code

@DonIsaac DonIsaac requested a review from nektro December 19, 2024 18:55
@robobun
Copy link

robobun commented Dec 19, 2024 •
edited
Loading

Updated 12:07 PM PT - Dec 19th, 2024

✅ Your commit 59687ba has passed in #8243! 🎉

🧪   try this PR locally:

bunx bun-pr 15885

@DonIsaac DonIsaac added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit f546a9b Dec 19, 2024
67 checks passed
@DonIsaac DonIsaac deleted the don/chore/check-node-usage branch December 19, 2024 23:44
probably-neb pushed a commit to probably-neb/bun that referenced this pull request Jan 7, 2025
@DonIsaac @probably-neb
chore: add usage messages to check-node.sh (oven-sh#15885)
b944c7d 
Co-authored-by: Don Isaac <don@bun.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nektro nektro nektro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonIsaac @robobun @nektro