Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(process): process.kill allows zero or negative pids #15920

Merged
merged 1 commit into from
Dec 21, 2024
Merged

fix(process): process.kill allows zero or negative pids #15920

merged 1 commit into from
Dec 21, 2024

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

Fixes #15791.

@robobun
Copy link

robobun commented Dec 21, 2024 •
edited
Loading

Updated 11:06 PM PT - Dec 20th, 2024

✅ @DonIsaac, your commit 8475845 has passed in #8391! 🎉

🧪   try this PR locally:

bunx bun-pr 15920

@DonIsaac DonIsaac enabled auto-merge December 21, 2024 05:22
@DonIsaac DonIsaac disabled auto-merge December 21, 2024 05:23
@Jarred-Sumner Jarred-Sumner added this pull request to the merge queue Dec 21, 2024
Merged via the queue into main with commit 14b44ae Dec 21, 2024
67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the don/fix/kill-negative-pid branch December 21, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process.kill should accept negative int
3 participants
@DonIsaac @robobun @Jarred-Sumner