Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make originalLine and originalColumn getter calls not observable #15951

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Make originalLine and originalColumn getter calls not observable #15951

merged 5 commits into from
Dec 23, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

  • We should do our best to avoid calling into JS inside error handlers when possible
  • node:util.inspect is displaying originalLine and originalColumn which messes with some node tests

How did you verify your code works?

Updated tests

@robobun
Copy link

robobun commented Dec 23, 2024 •
edited
Loading

Updated 2:54 AM PT - Dec 23rd, 2024

✅ @Jarred-Sumner, your commit 5e4cf07 has passed in #8446! 🎉

🧪   try this PR locally:

bunx bun-pr 15951

@Jarred-Sumner Jarred-Sumner merged commit 774e30d into main Dec 23, 2024
67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/observable branch December 23, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarred-Sumner @robobun