Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSObject instead of JSFunction in Bun.plugin #15968

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Use JSObject instead of JSFunction in Bun.plugin

Hopefully will fix this:

Bun v1.1.42 ([50eec00](https://github.com/oven-sh/bun/tree/50eec0025b482ad7b340c82f64749903b2fad4b8)) on macos aarch64 [AutoCommand]

Segmentation fault at address 0x00000000

1 unknown/js code
Bun::getIfPropertyExistsPrototypePollutionMitigationUnsafe
Bun::getIfPropertyExistsPrototypePollutionMitigationUnsafe
JSC__JSValue__fastGet
src.bundler.PluginRunner.onResolveJSC
src.bun.js.javascript.VirtualMachine.resolveMaybeNeedsTrailingSlash__anon_124181
Zig__GlobalObject__resolve
Zig::GlobalObject::moduleLoaderResolve
JSC::JSModuleLoader::resolve
JSC::moduleLoaderResolve

Features: Bun.stdin, jsc, spawn, transpiler_cache

How did you verify your code works?

@robobun
Copy link

robobun commented Dec 23, 2024

Updated 11:31 AM PT - Dec 23rd, 2024

@Jarred-Sumner, your commit 03d71af has 1 failures in #8462:


🧪   try this PR locally:

bunx bun-pr 15968

@Jarred-Sumner Jarred-Sumner merged commit 60cb505 into main Dec 23, 2024
66 of 67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/jsfunction branch December 23, 2024 20:33
probably-neb pushed a commit to probably-neb/bun that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants