Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toml build errors in Bun.build() #17473

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pfgithub
Copy link
Contributor

@pfgithub pfgithub commented Feb 20, 2025

What does this PR do?

Line text was not being cloned and then was freed before use

alternative solution: do the same thing bundle_v2 getAST .css does ← this doesn't work

@robobun
Copy link

robobun commented Feb 20, 2025

Updated 11:44 PM PT - Feb 21st, 2025

@pfgithub, your commit 5a58aec has 10 failures in Build #12075:


🧪   try this PR locally:

bunx bun-pr 17473

@pfgithub pfgithub changed the title Fix toml build logs Fix toml build errors in Bun.build() Feb 20, 2025
@pfgithub pfgithub marked this pull request as ready for review February 20, 2025 21:41
@pfgithub pfgithub marked this pull request as draft February 22, 2025 01:46
@pfgithub pfgithub force-pushed the pfg/fix-toml-build-logs branch from e883085 to 5a58aec Compare February 22, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants