Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brotli support #3541

Closed
wants to merge 11 commits into from
Closed

Add brotli support #3541

wants to merge 11 commits into from

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Jul 6, 2023

Doesn't work yet. Just the code to get it to compile, link, and the zig translate-c

  • Link
  • Expose on the Bun global
  • Expose in node:zlib
  • Support in fetch() (probably won't include this initially)

Note: this uses the latest HEAD commit instead of the last recently released version because Brotli seems to not have had a release in several years but the HEAD commit has several performance improvements.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@Jarred-Sumner 2 files with test failures on linux-x64-baseline:

  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#fb012d28a204b03e67f2b71533222efdd2658f39

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@Jarred-Sumner 2 files with test failures on linux-x64:

  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#fb012d28a204b03e67f2b71533222efdd2658f39

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@Jarred-Sumner 5 files with test failures on bun-darwin-aarch64:

  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#fb012d28a204b03e67f2b71533222efdd2658f39

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@Jarred-Sumner 8 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#3dcacafdcad1ca2ce52c6cb28cde15d9d0eeda48

@qweered
Copy link

qweered commented Jul 12, 2023

I believe it fixes #267 ?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

zig fmt errors have been resolved. Thank you.

#fb012d28a204b03e67f2b71533222efdd2658f39
zig v0.11.0-dev.4006+bf827d0b5

@marc-barry
Copy link

Make sure you don't make the same mistake Deno made which was addressed in denoland/deno#19758. I tried to port https://github.com/marc-barry/deno-spa-proxy to Bun but it is a no-go without Brotli support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants