Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash impacting sharp & resvg #4221

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Fix crash impacting sharp & resvg #4221

merged 1 commit into from
Aug 20, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

The implementation of napi_create_external_arraybuffer and napi_create_external_buffer was wrong. It called the finalizer with incorrect arguments, causing a crash when the memory is freed. This calls the finalizer with the expected arguments.

How did you verify your code works?

Integration test via resvg. Manually tested sharp as well.

@github-actions
Copy link
Contributor

@Jarred-Sumner 1 files with test failures on linux-x64-baseline:

  • test/js/web/fetch/fetch.test.ts

View test output

#9a27d89922de52d84c65189adb1d46c12a805e4d

@Jarred-Sumner Jarred-Sumner merged commit 507761b into main Aug 20, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/sharp branch August 20, 2023 01:17
@github-actions
Copy link
Contributor

@Jarred-Sumner 6 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/worker.test.ts

View test output

#9a27d89922de52d84c65189adb1d46c12a805e4d

@github-actions
Copy link
Contributor

@Jarred-Sumner 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/fetch/fetch.test.ts
  • test/js/web/streams/streams.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#9a27d89922de52d84c65189adb1d46c12a805e4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant